Jump to content
Killersites Forums

Recommended Posts

Hello All,

 

I still can't get my favourite icon to show in IE, it shows in Firefox

 

I use the code

 

<link rel="shortcut icon" href="/favicon.ico" />

 

I have the icon in the root directory but still no show!

 

Thank you,

 

Best wishes

Graeme

Link to post
Share on other sites

I probably wouldn't even worry about the favicon at this time. I think you have bigger issues, but try adding this line:

<link rel="shortcut icon" href="http://www.standrews-chiltonmoor.org.uk/favicon.ico"/> 

and see if that makes a difference.

 

Since I looked, I also noticed the following:

  • You have THREE sets of body tags
  • Your header displays to the left of your content (Hallo there starts somewhere between 'about us' and 'services'.
  • You have more div closing than opening tags
  • Your menu is missing the final closing ul tag
  • H2 tags aren't closing properly - and they are not being used semantically correct.
  • Incorrect use of a table for the images in your footer - and the table cells aren't closing properly, plus there are 2 empty cells.

Hope that helps.

 

Link to post
Share on other sites

Thank you Andrea,

 

Very much appreciated. I think I have corrected my errors, the only thing is could you explain

 

Incorrect use of a table for the images in your footer - and the table cells aren't closing properly, plus there are 2 empty cells

 

Thank you as always,

 

Best wishes

Graeme

Link to post
Share on other sites

Incorrect use of a table for the images in your footer - and the table cells aren't closing properly, plus there are 2 empty cells

There are three images in your footer which does not equate to tabular data. Tables are meant to be used to display tabular data. Of course it's your decision to use a table anyway, but you have some coding errors:

 

<table>
<tr>
     <td>durhamdiocese.jpg</td>

     <td>stmathews.jpg  ---- Closing TD Tag Missing

	<td>premier.jpg</td>
     </td>    ------ Redundant Closing TD TAg
   <td></td>
     <td></td>  
</tr>

</table>

Look at this - you have the 3 images each in a cell, only 2 open and close properly, but in the next line, there's a redundant cell closing tag - and following that, you have 2 sets of empty cells - no reason for those, you only have 3 images.

 

Also, I still see errors on your index page - your division opening and closing tags don't all pair up, and a closing header tag is written </h2> and not </ h2>

 

Don't have time at the moment to research your div issue, but I'm looking at your source via FX's Webdeveloper Toolbar 'Show Source' and there I see red tags which indicate errors.

Edited by Andrea
Forum Screwing up how code is posted.... GRRR
Link to post
Share on other sites

Thank you Andrea and Eddie, much appreciated. I've had another play with the code Andrea but I look forward to hearng from you but please, there is no rush

 

Best wishes

Graeme

 

Ok - I'm home now and about to tackle your code - meanwhile, this is how the site looks as I view it in Firefox with a resolution of 1600 px wide.

 

graeme.jpg

Link to post
Share on other sites

I have been fiddling with this - please pay attention to my comments: http://aandbwebdesig...Sforum/sta.html

 

It's still not right, but I'm out of time now. You really need to validate your pages - there are a lot of errors. You're using an XHTML doctype (should be HTML) and with the XHTML doctype, all tags must be closed - that includes all your meta tags, br tags, img tags, all of them.

You are using symbols like > instead of &gth;

Your closing blockquote is missing

Your don't have the same number of opening as closing div tags

The menu list has coding mistakes

You're using the H2 tag not the way header tags are supposed to be used

 

That's all I can remember, but I left comments in the code as I fixed stuff.

 

The page still does not line up - header still too far to the left, but I don't have time to look at the CSS or to see if I missed something else. Overall, VALIDATE --- ALWAYS VALIDATE -- granted, some errors come with the territory, like some created by the javascript stuff, but it will also catch the blatant mistakes - like missing or too many closing tags.

 

Let me know if you have any questions, but this should help you towards cleaning up at least a bit.

Link to post
Share on other sites

Thanks again Andrea,

 

I'm on a roll and learning loads at the same time!

 

Firstly I'm baffled about

 

XHTML doctype (should be HTML) and with the XHTML doctype, all tags must be closed - that includes all your meta

 

I'm not sure about the closing tags, should they be </> or < />

 

The Doctype on my index page is

 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en-GB">

 

what do I need to change?

 

Thank so much,

 

Best wishes

Graeme

 

also thank you for putting the comments in, they have been a great help

Link to post
Share on other sites

This thread: http://www.killersit...rch__1#entry168 gives you all the info about HTML / XHTML you will ever want.

 

The closing tags depend. Those that have their own closing tag, you write like this:

<h2> </h2> - (you had an incorrect space between the / and the h in your code)

Those that don't have a closing tag, like meta, img, br, hr, you write like this:

<img src="whatever.jpg" alt="whatever" /> or
<br />

 

Back to the doctype - if you were to switch to HTML, you'll need:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">  

but then you'd have to unclose all those meta and image tags, etc.

 

Or, you could just switch to the doctype that comes new with HTML5:

<!DOCTYPE html> 

 

With that, closed and none-closed tags are acceptable (depending on the tag that is) - but for this discussion (meta, img, br, hr), either way is ok. However - while HTML 5 does not bark at a < /br> - it's not necessary. So for this page, I'd leave them, but on your next site, I'd not add anything that's not required.

Link to post
Share on other sites

Wey hey, getting there I think ndrea, only 15 errors now and most of those are that I can't and understand that it is difficult to get Flash movies to validate.

 

Just to recap, should the br tags be like this </ br> or <br /> and what should the like meta, img, br, hr's be coded like?

 

Wow what a learning curve today!

 

Thank you and thnanks again,

 

Best wishes

Graeme

Link to post
Share on other sites

Look at my last post - I'd screwed up when I told you about the closing br tag, but I edited and it shows correctly now.

 

The img tag is correct, and it's the same as the meta tag.

Link to post
Share on other sites

Got it Andrea, I'll use <br /> I was just reading a tutorial on HTML 5 after advice from a friend.

 

A lot of the errors are associated with

 

The language attribute on the script element is obsolete. You can safely omit it.

 

<script LANGUAGE="JavaScript">function openwin(UrlName) {

 

does this mean I don't have to include the script name?

Link to post
Share on other sites

Sometimes, you can't help those errors created by JavaScript stuff. The reason I find validation so useful is because it helps find mistakes that can lead to real problems. (like mis-matched opening/closing tags).

 

I tried to validate your site to see exactly what you're getting, but I just got this:

 

Sorry, I am unable to validate this document because on line 64 it contained one or more bytes that I cannot interpret as utf-8 (in other words, the bytes found are not valid values in the specified Character Encoding). Please check both the content of the file and the character encoding indication.

 

The error was: utf8 "\xA9" does not map to Unicode

 

 

 

Not sure what you did in line 64. Btw, the line regarding this encoding should actually be right after the head opening tag.

Link to post
Share on other sites

Remove the closing slash from your charset:

<meta charset="utf-8">

 

Remember - closing tags are not needed with HTML5, but technically, shouldn't cause a problem.

 

But maybe here, they do - try it and see if it fixes the validation error.

Link to post
Share on other sites

A few more points:

 

I don't really know JavaScript, but it appears you have a script to open a window in your head section THREE times. I don't know why you need this at all, windows open all by themselves just by clicking links.

 

Looks like you pretty much just copied / pasted my version onto the website. Not a problem with that, but anybody looking at your code will find those comments I left just so I could explain to you what I was doing somewhat odd.

 

This one I'm not sure about, but look at your flash coding - your embed tag is closing twice - once at the end of the opening tag and again with a regular closing embed tag (which, btw, is red on my view source, usually indicating an error.) Since I'm seeing the regular closing embed tag, I'd recommend you remove the closing slash that's currently inside the embed tag and see what that gets you.

 

Instead of that table, just float those images next to each other and make adjustments with margins as needed.

 

The reason that your header is off is that you set your container div at 90% which of course means its width will vary from resolution to resolution. For example, on my wide monitor, I'm seeing it 1440 wide. Your flash 'box', however, is only 921 px wide - so there are 519 px of empty space left. Even if you center the flash, it won't work since as your container changes width, so does the content, while the flash box is fixed. Just set the width of your container to px to match what you need for the flash and you're set.

 

As to the improper use of the h2 tag on your page, this link should explain how header tags are supposed to be used: http://www.w3schools...ml_headings.asp

 

Brief look at the CSS: there is no such thing as 'float: center'

Link to post
Share on other sites

The reason the document could not be validated is because it contains a (byte order mark).-not visible.

which can be removed using (programmers notepad)

I did this for you and uploaded it to my server.

here is the w3c validation page.

http://validator.w3....=Inline&group=0

 

 

Here is the code on my server, you can start over with this code at least you can validate and fix problems.

http://www.coollew.com/test.html

 

Also this is how to write your flash code so it validates.

 

 

<object type="application/x-shockwave-flash"

data="banner.swf"

width="921" height="200">

<param name="movie" value="banner.swf" />

<param name="quality" value="high"/>

</object>

Edited by coollew
Link to post
Share on other sites

Thanks so much you two, I really appreciate all the help.

 

I managed to get this piece of code to go

 

on line 64, which has the following.

* Bookmark site script- Dynamic Drive DHTML code library (www.dynamicdrive.com)

 

Also Coollew, could I replace all of the code I have with the code you suggested to get the movie to run and validate, it seems a lopt less code than I had?

 

Best wishes

Graeme

Link to post
Share on other sites

Yes the code for the flash should work the way i wrote it for ya I didn't have the flash file to test.

I no longer use flash but it worked for me in the past.

As Andrea said you have a lot of issues to address, in my opinion you should review them and take one thing at a time.

Time constraints prevent me from helping as much as i would like.

 

p.s.I prefer j query over flash for your purpose .

Link to post
Share on other sites

Thank you, I'll follow your advice. Can I just ask one more thing? Do I replace all of the code for the Flash movie with yours? I tried this and the movie wouldn't show! Or do I replace some some with the code you gave me?

 

Thanks again,

 

Best wishes

Graeme

Link to post
Share on other sites

Graeme, the flash works. The validation error here I think can wait, it affects nothing other than the page not getting a green passing flag. However, the fact that your header and top navigation are misaligned is clearly visible to everyone. I'd think it may be more important to fix that and then worry about the under-the-hood stuff nobody notices.

Link to post
Share on other sites

Hello again,

 

I used Coollew's advice for the flash code and it is great now, thank you. It validates now all except a few issue. I set the top image width to 921 insread of 90%. All seems good at the resolution I use but I'm wondering about it again Andrea.

 

Thanks,

 

Best wishes

Graeme

Link to post
Share on other sites

The top image isn't the problem. The problem is that you have the container set at a width of 90%. I still see this:

graeme2.jpg

 

As I said in an earlier post:

The reason that your header is off is that you set your container div at 90% which of course means its width will vary from resolution to resolution. For example, on my wide monitor, I'm seeing it 1440 wide. Your flash 'box', however, is only 921 px wide - so there are 519 px of empty space left. Even if you center the flash, it won't work since as your container changes width, so does the content, while the flash box is fixed. Just set the width of your container to px to match what you need for the flash and you're set.

 

If you cannot increase your resolution or view the page from a different monitor that has one, then just decrease yours - you'll see how the 90% container will shrink to less than the 921 px and things won't line up any more either.

Link to post
Share on other sites

Now I see it - must have been looking at a cashed version.

 

The nav is still a little off - starts even with the image oh the left side, but ends about 35px before the right corner of it.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
×
×
  • Create New...