Jump to content
Killersites Forums

Opinion On Portfolio Site


Recommended Posts

I don't like that the Facebook and Twitter link take you away from the site. I mean, that's what those two things are supposed to do, but your links appear right with the rest of your site navigation. Then I think your regular font color should be just a bit darker for easier reading for those with issues, especially the 'labels' on your contact page. They are very faint.

 

As to your code, I don't know this for a fact, but it seems that using the article tag as some sort of division tag may be improper use of the tag. Don't know if that hurts anything, but I like semantics. :)

Link to post
Share on other sites

I don't like that the Facebook and Twitter link take you away from the site. I mean, that's what those two things are supposed to do, but your links appear right with the rest of your site navigation. Then I think your regular font color should be just a bit darker for easier reading for those with issues, especially the 'labels' on your contact page. They are very faint.

 

As to your code, I don't know this for a fact, but it seems that using the article tag as some sort of division tag may be improper use of the tag. Don't know if that hurts anything, but I like semantics. :)

Thanks for bringing up the article tag. I will definitely look into that.

Link to post
Share on other sites

As to your code, I don't know this for a fact, but it seems that using the article tag as some sort of division tag may be improper use of the tag. Don't know if that hurts anything, but I like semantics. :)

I looked into use of <article> & <section> tags and I understand that article represents more general areas such as a parallax scroll image div, and the section may represent overlaying text on the image

Link to post
Share on other sites

I guess it depends on where you look. But from here: http://www.w3schools.com/html/html5_new_elements.asp and here https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/HTML5_element_list I'd take it a bit differently.Also, I would hope that the actual meaning of the word section and article was considered during the development of html5.

  • Upvote 1
Link to post
Share on other sites

I guess it depends on where you look. But from here: http://www.w3schools.com/html/html5_new_elements.asp and here https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/HTML5_element_list I'd take it a bit differently.Also, I would hope that the actual meaning of the word section and article was considered during the development of html5.

Yeah I personally find it very confusing and I think their is quite a grey area. I don't see anything about either tags that could break your code used improperly alone, but having valid code is an important asset to being a professional. I might play around with some scenarios and use a code validator. :)

Link to post
Share on other sites

At least for me, I think of it this way:

 

-- I use <article> for a block of related text content, for content that is intended to be read together (for example, a blog post and the post title). I usually think of an RSS feed: would this content be something you would consider posting on an RSS feed? Does it stand on its own, without the need for additional context? I usually would use only one article tag per page, to specify what I consider to be the most important content on the page.

 

-- I use <section> like I would use a <div> tag, but I think of it as a more specific div, something that indicates a grouping of related content. For example, I might have a banner section, or a main section (that might contain an article and a sidebar), etc. I use it to group chunks of related content and code, and I'll use divs within the section for less semantically important items.

 

 

On your site, considering it's limited content, I would probably make #main, #me, #work and #contact <sections>. I'd make the #footer a <footer>. And unless you have a page that has a more significant amount of content, I wouldn't have any <article> tags at all.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
×
×
  • Create New...