Jorge Posted March 6, 2018 Report Share Posted March 6, 2018 Can I please get your opinion on this piece of js code. Which way is better or correct between the two version, I know both work but I am curious if of one of the 2 is better or both or if none. This one: document.getElementById("startEd").onclick = function startEdit () { //Make the element editable var element = document.getElementById("editableElement"); element.contentEditable = true; element.focus(); } Or this one: function startEdit () { //Make the element editable var element = document.getElementById("editableElement"); element.contentEditable = true; element.focus(); } //Runs the StartEdit function when button is clicked document.getElementById("startEd").onclick = function() { startEdit(); } This is the HTML just in case: DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <title>Editable Content</title> <link rel="stylesheet" href="css/editableElement.css"> </head> <body> <main> <button id="startEd">Start Editing</button> <button id="stopEd">Finish Editing</button> <p id="editableElement"></p> </main> <script type="text/javascript" src="js/editableElement.js"></script> </body> </html> Quote Link to comment Share on other sites More sharing options...
administrator Posted March 6, 2018 Report Share Posted March 6, 2018 I would go with #1 because it is less code but still very readable. Stef Quote Link to comment Share on other sites More sharing options...
Jorge Posted March 6, 2018 Author Report Share Posted March 6, 2018 Thanks Another question, is there a better way? Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.