Jump to content
Killersites Forums

AnthonyJ site critique pt22


Recommended Posts

And last time I looked at your coding, you were not using XHTML doctype - unless that's changed, the closing slash in the img tag is also wrong.

Link to post
Share on other sites
  • 1 month later...

It is really better if you start a new thread for a new problem/question/issue - and it's easiest for us to help if you have a link. That way, we can see html, CSS AND the images. It's also helpful if you describe the problem, unless it's obvious when looking at the linked page. Just 'wrong' and the CSS you uploaded don't tell me anything - I can only guess.

 

Is your image not showing up?

 

Is it showing up, but not where/how you want it? (So what is it doing and what should it be doing?)

 

Looking at your CSS I only see for sure - and that has nothing to do with a background image - that this is wrong:

*
{
margin: 0px auto;
padding: 0px auto;
color: #000;
}

It should look like this:

*
{
margin: 0;
padding: 0;
}

 

The * is the universal place holder - by using it, you apply whatever you write there to every single tag in your entire page/site. My version is used to remove any default paddings or margins from anything that comes with one. For example, paragraphs have different margins/paddings, depending on what browser. By making them all zero at first, and then adding them back in later as you want, makes it easier to have your pages look more the same across browsers. I guess adding the color isn't exactly wrong, but unusual - mostly, global colors are added to the body or html tag.

 

Adding the right-left margin of auto is done to center things. You don't want everything centered (hopefully). That part is mostly added to a wrapper division which centers your content division on the monitor.

 

And - and that's one of my many pet peeves: When you say '0', you mean zero anything, so there's no need to say 0px - just 0 will make everything zero: px, em, %, cm, whatever. Adding the 'px' to the '0' isn't wrong, just redundant.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
×
×
  • Create New...