Jump to content
UncleStef Mentoring Update: New SEO course!

Jorge

New Members
 View Profile  See their activity

  • Posts

    2

  • Joined

  • Last visited

 Content Type 

Posts posted by Jorge

  2. Which way is more elegant

    in Beginners Web Design

    Posted

    Can I please get your opinion on this piece of js code.

    Which way is better or correct between the two version, I know both work but I am curious if of one of the 2 is better or both or if none.

    This one:

    document.getElementById("startEd").onclick = function startEdit () {
        //Make the element editable
        var element = document.getElementById("editableElement");
        element.contentEditable = true;
        element.focus();    
    }

    Or this one:

     function startEdit () {
        //Make the element editable
        var element = document.getElementById("editableElement");
        element.contentEditable = true;
        element.focus();    
    }
    //Runs the StartEdit function when button is clicked
    document.getElementById("startEd").onclick = function() {
         startEdit();
    }    

     

    This is the HTML just in case:

    DOCTYPE html>
    <html lang="en">
    <head>
        <meta charset="UTF-8">
        <title>Editable Content</title>

        <link rel="stylesheet" href="css/editableElement.css">

    </head>
    <body>

        <main>

            <button id="startEd">Start Editing</button>
            <button id="stopEd">Finish Editing</button>

        <p id="editableElement"></p>

        </main>

    <script type="text/javascript" src="js/editableElement.js"></script>    

    </body>
    </html>

×
×
  • Create New...