oggyswain Posted April 30, 2012 Report Share Posted April 30, 2012 I cant get these links to work, Any suggestions. Here is the Link the http://www.burkedirectmail.com/reference.html Try these links on the left side. Important Links Canada Post USPS Weight Conversion Quote Link to comment Share on other sites More sharing options...
falkencreative Posted April 30, 2012 Report Share Posted April 30, 2012 I would start by fixing these errors -- looks like you have some missing closing tags: http://validator.w3.org/check?uri=http%3A%2F%2Fwww.burkedirectmail.com%2Freference.html&charset=%28detect+automatically%29&doctype=Inline&group=0 Fix those, and then see if those links start working? Quote Link to comment Share on other sites More sharing options...
oggyswain Posted April 30, 2012 Author Report Share Posted April 30, 2012 Can you give me an example of how to fix one of these. I am unsure how to fix them. If you can show me how to correct one I can probably fix the rest. Thanks Quote Link to comment Share on other sites More sharing options...
falkencreative Posted April 30, 2012 Report Share Posted April 30, 2012 For example, the second error from the validator: <a href="sitemap.html">Sitemap | It's just saying that the link needs a closing </a>. Quote Link to comment Share on other sites More sharing options...
oggyswain Posted May 2, 2012 Author Report Share Posted May 2, 2012 Fixed the errors but the links still dont work. Any ideas? Quote Link to comment Share on other sites More sharing options...
benjaminmorgan Posted May 2, 2012 Report Share Posted May 2, 2012 I'm pretty sure you forgot to close something or closed something that didn't exist. (When you click the links the page content disappears.) That is the only reason I have seen links not go before. Make sure everything is closed. Quote Link to comment Share on other sites More sharing options...
oggyswain Posted May 2, 2012 Author Report Share Posted May 2, 2012 Why would the Links on the right work but not the ones on the left? Quote Link to comment Share on other sites More sharing options...
oggyswain Posted May 2, 2012 Author Report Share Posted May 2, 2012 This is the code for that section. <div class="box"> <div class="padding1"> <h2 class="p3">Important Links</h2> <ul class="tabs"> <li><a href="http://www.canadapost.ca/cpotools/apps/track/business/findByTrackNumber?execution=e2s1">Canada Post</a></li> <li><a href="https://www.usps.com/">USPS</a></li> <li><a href="http://www.metric-conversions.org/weight/kilograms-to-pounds.htm">Weight Conversion</a></li> </ul> </div> </div> It appears to be ok? Quote Link to comment Share on other sites More sharing options...
Andrea Posted May 2, 2012 Report Share Posted May 2, 2012 Check all those divisions you have surrounding this list - I randomly deleted several of them, and the links started to work. I did not check into this in detail, I'd have to look through the CSS for each of them. There really should not be any reason you need so many division here - I'd start over and keep it simple. Use only a division if one is needed. You can apply ID's or classes to a ul tag and define it that way, and may not need a single division around it at all, but I don't see any single reason where you actually need all the divisions you are using on the entire site. And when you do use divisions, give them meaningful class or ID names - grid 4 alpha will likely not mean a whole lot to you 3 months later. Quote Link to comment Share on other sites More sharing options...
oggyswain Posted May 2, 2012 Author Report Share Posted May 2, 2012 Hi Andrea, Its a template from template monster and I am starting to wonder if I should just start creating my own site. I use them to save time but this is not saving time. Quote Link to comment Share on other sites More sharing options...
Andrea Posted May 2, 2012 Report Share Posted May 2, 2012 You'd learn a lot more recreating your own - and it's always a bit PITA to try and figre out what someone else has done, especially when it's as cluttered at this template. Nothing wrong with templates - if there's nothing wrong with the one you're using Quote Link to comment Share on other sites More sharing options...
benjaminmorgan Posted May 2, 2012 Report Share Posted May 2, 2012 Lol Andrea. I prefer hand coding my own designs as well. I hate figuring the stuff out on templates. And you do learn loads more by recreating. It is probably faster as well. Quote Link to comment Share on other sites More sharing options...
oggyswain Posted May 2, 2012 Author Report Share Posted May 2, 2012 Everytime I try to delete any of the closing div's. I get an error on the page. Sorry that I am not very good at this but if you can telling which one you deleted maybe it will make more sense to me. Quote Link to comment Share on other sites More sharing options...
Andrea Posted May 2, 2012 Report Share Posted May 2, 2012 I cannot tell you which ones to delete without seeing what they all do, I was just deleting blindly using the 'Edit HTML' in my FX Webdeveloper's bar. I would seriously consider recreating this page from scratch - the layout is not that difficult, and you'll learn a lot more. The way this is coded right now, you almost have more divisions than you have content. Example - a division class for padding - makes no practical sense. Just add the padding to the 'mother'division's CSS. Quote Link to comment Share on other sites More sharing options...
oggyswain Posted May 2, 2012 Author Report Share Posted May 2, 2012 I see what you mean Thanks Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.