Jump to content

Hyperlink on steroids


yesdavy

Recommended Posts

I poked around your site for quite a while this morning, but couldn't identify anything yet. It seems like just a simple image that's a link. My best guess right now is that maybe somewhere in all that CSS, a display: block is applied to the a tag - not sure, but it's all I got right now.

 

You really should do some cleanup on that site, so - loads of validation errors, and all those styles do NOT belong into the body section.

Link to comment
Share on other sites

It looks like your image source is not closed, and also, why is part of the URL pasted again at the end before you close the hyperlink?

 

What if you change

 

<a href="http://marketmoodforecast.com/wordpress/?feed=rss2"><img src="http://www.marketmoodforecast.com/wordpress/wp-content/themes/genesis-2/images/rss-icon.png" Target-"_blank" alt="Subscribe to RSS" align="center" border="0"http://marketmoodforecast.com/wordpress/wp-content/themes/genesis-2</a>

 

to

 

<a href="http://marketmoodforecast.com/wordpress/?feed=rss2"><img src="http://www.marketmoodforecast.com/wordpress/wp-content/themes/genesis-2/images/rss-icon.png" Target-"_blank" alt="Subscribe to RSS" align="center" border="0"></a>

Link to comment
Share on other sites

Also another error in the code is your target, which should read:

 

target="_blank"

 

You have a dash instead of equals, so the hyperlink is using the current window instead.

 

After making the changes in the two JasonDavis replies, the hyperlink no longer extends down into the search form, but still stretches too far left and right to the margins of the sidebar.

 

I was noticing that Killersites.com has the same issue above in the logo hyperlink (it extends north and south too far) and the sign in hyperlink extends east (right) well beyond the underlined words.

Link to comment
Share on other sites

I agree with Andrea.

 

One thing that has been extremely helpful to me as I've learned HTML and CSS is Google Chrome's "inspect element" tool. If you're more of a Firefox person I believe Firebug can do the same thing. Look at this screenshot from when I inspected that element of your site. See how Chrome is convinced your RSS image is 300x58? Something must not be closed prior to that.

 

Screenshot.png

Link to comment
Share on other sites

Be careful, so - that mistake in the link to your rss image that you had earlier, did not show in Firebug or the Edit CSS/Edit HTML option in the Firefox Webdeveloper toolbar, that I was using - that code appeared correct, even so it was not (the closing tag was missing and a space was missing).

Link to comment
Share on other sites

Be careful, so - that mistake in the link to your rss image that you had earlier, did not show in Firebug or the Edit CSS/Edit HTML option in the Firefox Webdeveloper toolbar, that I was using - that code appeared correct, even so it was not (the closing tag was missing and a space was missing).

 

Andrea and Jason, thanks so much. I have Chrome so I will use it now that I know about this inspect element feature.

I looked for the dimensions but never found them and still am not sure how to find them to edit. Sorry for being such a newbie.

Link to comment
Share on other sites

I usually use the Firefox Webdeveloper toolbar - but you can go directly there: http://www.w3schools.com/site/site_validate.asp

 

Wow, this should help a lot! Look at all the errors.

When looking at the source code it combines several .php files combined together to create the page. The validation app shows the line and column for the source code view. I guess the line and column info is of no use in finding the error locations if I have to go to each individual php file to make the changes. At least I have something to go by now.

 

How do all these mistakes happen? At first glance, many of these things seem to be in the Word Press theme because I do not recognize having altered them, e.g., <div id="page"><style type="text/css"> and this one was copied directly from Fox News <embed src="http://www.foxnews.com/i/redes/ticker.embed.swf" type="… and many are in the widgets I copied and pasted.

 

Is it common for WP themes to have invalid code?

Link to comment
Share on other sites

I wouldn't even worry about those kind of errors at this time - some can't be avoided, and you'll just have to live with them. Mainly, look for tags you forgot to close - those are what effects the layout.

 

I see, so is there any way to use the line info from the validation site you gave me to locate an issue? It shows:

 

Line 91, Column 255: end tag for "img" omitted, but OMITTAG NO was specified…lt="marketheist freestockcharts stock chart plugin certification" title=""></a>

You may have neglected to close an element, or perhaps you meant to "self-close" an element, that is, ending it with "/>" instead of ">".

 

I copied "marketheist freestockcharts stock chart plugin certification" title=""></a> and did a Ctrl+ F search in index.php and sidebar.php and style.css but found nothing. How am I to find this in order to correct it?

I just went back through all the tag errors, about 6 of them, and without knowing how to locate them by line number, I copied relevant information in the tag and did a Ctrl+ F search for all of them in index.php and sidebar.php but nothing is found.

 

So, I went to view source and located the line numbers referenced in the W3C validation app and the tags the app says are not closed are indeed closed, to wit.,

 

Line 121, Column 21: end tag for "ul" which is not finished </ul>

 

Most likely, you nested tags and closed them in the wrong order. For example <p><em>...</p> is not acceptable, as <em> must be closed before <p>. Acceptable nesting is: <p><em>...</em></p>

 

Another possibility is that you used an element which requires a child element that you did not include. Hence the parent element is "not finished", not complete. For instance, in HTML the <head> element must contain a <title> child element, lists require appropriate list items (<ul> and <ol> require <li>; <dl> requires <dt> and <dd>), and so on.

 

Line 129, Column 5: end tag for "ul" which is not finished</ul> </div>

 

Most likely, you nested tags and closed them in the wrong order. For example <p><em>...</p> is not acceptable, as <em> must be closed before <p>. Acceptable nesting is: <p><em>...</em></p>

 

Another possibility is that you used an element which requires a child element that you did not include. Hence the parent element is "not finished", not complete. For instance, in HTML the <head> element must contain a <title> child element, lists require appropriate list items (<ul> and <ol> require <li>; <dl> requires <dt> and <dd>), and so on

Link to comment
Share on other sites

Line 91, Column 255: end tag for "img" omitted, but OMITTAG NO was specified…lt="marketheist freestockcharts stock chart plugin certification" title=""></a>

You may have neglected to close an element, or perhaps you meant to "self-close" an element, that is, ending it with "/>" instead of ">".

 

I went to "view source' and did the Ctrl+F for just 'stock chart plugin" and I found 3 occurrences and all are missing the closing slash inside the image tag. Your doctype is XHTML, so the img tag needs to be closed.

 

  1. error.pngLine 112, Column 6: end tag for "h2" omitted, but OMITTAG NO was specified </div><!--/page -->
     
    You may have neglected to close an element, or perhaps you meant to "self-close" an element, that is, ending it with "/>" instead of ">".

 

If you search for </div><!--/page --> you find

 

<!--/sidebar -->  
<h2 class="right"><a href=http://www.gocurrency.com/ id=gocurrency>Currency Converter</a> 
<script src= [url="http://www.gocurrency.com/v2/gocurrcalc_t.php?id=53%3E"]http://www.gocurrenc...lc_t.php?id=53>[/url] </script>


  <hr class="clear" />
</div><!--/page -->
</div><!--/wrapper -->

And there you can see the h2 opening, but never closing - find the page that contains that portion of the code and fix it there.

 

And so forth - it'll take a bit, but it'll be worth it.

Link to comment
Share on other sites

I went to "view source' and did the Ctrl+F for just 'stock chart plugin" and I found 3 occurrences and all are missing the closing slash inside the image tag. Your doctype is XHTML, so the img tag needs to be closed.

 

 

 

If you search for </div><!--/page --> you find

 

<!--/sidebar -->  
<h2 class="right"><a href=http://www.gocurrency.com/ id=gocurrency>Currency Converter</a> 
<script src= [url="http://www.gocurrency.com/v2/gocurrcalc_t.php?id=53%3E"]http://www.gocurrenc...lc_t.php?id=53>[/url] </script>


  <hr class="clear" />
</div><!--/page -->
</div><!--/wrapper -->

And there you can see the h2 opening, but never closing - find the page that contains that portion of the code and fix it there.

 

And so forth - it'll take a bit, but it'll be worth it.

 

 

When I search (Ctrl+F) in Dreamweaver </div><!--/page --> is not found on any page or on style.css so I am missing something here. I knew where this go currency code you found was located and it was an easy fix. The code came from a widget to convert currency so they must have omitted it because I did a select all and copied their code. If I view source and match the line numbers referenced in the W3C validation app, the errors reported in W3C do not appear to exist in view source. I am either really dumb or really confused, probably both.

 

In re-reading your comment I see that you are using Ctrl+F in view source, duh, I am really dumb. Let me go back over these again. Thanks for now and sorry to bother you, Andrea.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
×
×
  • Create New...