Jump to content
Killersites Community
Hersarma

functions

Recommended Posts

Hello all.

So i have a question about functions.

Example:

I like to change css style on multiple id's in a function like this.

/ *

function endGame () {
   
     document.getElementById ('easybtn'). style.display = 'none';
     document.getElementById ('mediumbtn'). style.display = 'none';
     document.getElementById ('hardbtn'). style.display = 'none';
     document.getElementById ('randombtn'). style.display = 'none';
     document.getElementById ('textOutput'). style.display = 'none';
     document.getElementById ('hide'). style.display = 'none';

}

* /

But it looks like a lot of repiting.

So i made another function where i used array of id's and use foor loop.

/ *

var ids = ['easybtn', 'mediumbtn', 'hardbtn', 'randombtn', 'textOutput', 'hide']

function endGame () {
     for (var i = 0; and <ids.length; and ++) {
         document.getElementById (ids ). style.display = 'none';
     }

* /
They both work
But what function is bether to use in this situation or is there even a bether way.

Ty.

And sry for my bad english.

Share this post


Link to post
Share on other sites

Hi,

Your second option where you use an array is better, since it is cleaner code. That said, you could also use the element hierarchy in the DOM to target elements. But what would be the point?

Another thing you can do, if possible, is place all those elements into a div and simply toggle the visibility of the div. But I am guessing the elements are in different parts of the page. 

Stef

Share this post


Link to post
Share on other sites

Ty for answer. And yes they are all in one div except one tag. I try to move that tag in another div. Or i can delete that div and add another div in same place whit a function. But any way ty😊

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×