function data repeat

[akurtula]

i have not been able to figure this out since i have started looking at oo programing:

 

function dis_books($key){
while ($row = mysql_fetch_array($this->result,MYSQL_ASSOC))
   {
   return  $row[$key];
   } 
}
}

 

in the database, i have 5 items; with the above code, i only get the first record:

 

also if i echo rather than return the above, it works ( by showing all records) but then i cant reuse it again e.g

 

   <?php     $con->dis_books(images); ?>



<?php     $con->dis_books(books); ?>

 

is there something that i am missing ?

 

thanks for the help

[falkencreative]

I'm not 100% sure I understand what you are attempting to do... Try this though, and see if it does what you want? Basically, the important change is that I have created an array that gets added to during the while loop, rather than just returning the first item in the array. Once the while loop is finished, then the array is returned.

 

function dis_books($key){
while ($row = mysql_fetch_array($this->result,MYSQL_ASSOC))
   {
   $row[] = $row[$key];
   } 
}
return $row[];
}

[akurtula]

thanks for the better explenatio, that's exactly what i need to got - the full array.

 

the code you give looks good though i am getting this error

 

fatal error: cannot use[] for reading in c:\xampp....

 

how can this be solved?

 

thanks for the help

[falkencreative]

My mistake -- I should be returning "$row" not "$row[]". Also noticed that I didn't catch an earlier mistake (an extra "}")

 

Try this instead:

 

function dis_books($key){
   while ($row = mysql_fetch_array($this->result,MYSQL_ASSOC))
   {
       $row[] = $row[$key];
   } 
   return $row;
}

[akurtula]

<?php
$con = new Connection_class();
?>

<?php echo $con->dis_books(title); ?>

<?php echo $con->dis_books(author); ?>

[falkencreative]

OK, further tweaks... and I've actually tested this, and it has worked for me on a temporary database.

 

function dis_books($key){
   while ($row = mysql_fetch_array($this->result,MYSQL_ASSOC))
   {
       $array[] = $row[$key];
   } 
   return $array;
}

 

If you are still having trouble after this, perhaps you can post any errors (though there shouldn't be?) or what the function is returning for you?

[akurtula]

hi

 

the above code only gives me the word "array" on the page, therefore no error message

 

though, as it is an array, i tried to then print it using "print_r" just to see what is doing, and it does show that it is holding the records

 

Array ( [0] => Build Your Own Website The Right Way Using HTML & CSS [1] => HTML Utopia: Designing Without Tables Using CSS [2] => Simply JavaScript [3] => Build Your Own Database Driven Website Using PHP and MySQL [4] => No Nonsense XML Web Development With PHP )

 

apart from the 4th entry which is not part of my items - now this is getting strange (the array is getting strange)

 

 

thanks

[falkencreative]

Well, you can't simply show array like this: echo $con->dis_books(title); Because it is an array, you'll need to loop through and echo each item separately.

 

As far as the "4th entry not being part of your items", you'd better look at your database. I'm quite sure there isn't an issue with the code... it is only pulling the results you specify.

[falkencreative]

as a quick example, you could loop through and display an array like this (adding a "
" between items):

foreach ($array as $i => $value) {
   echo $array[$i] . "
";
}

[akurtula]

thanks for the help

 

a have done this kind of thing before but using the procedural coding - and this was my first time using the class and i got so mixed up - i got so confused and annoyed with this that i did not realize that the 4th item has part of my database record

 

but once again thanks alot