We just installed our new forum/community .. please check it out: Killersites Community. THIS FORUM IS NOW AN ARCHIVE. Old user accounts and posts have been transferred to the new forum.
I've started a new topic on the move here TALK ABOUT NEW FORUM
Stefan
Ive been learning coding (the best i can with anything i can find online) since just before xmas, and did this on a free web host for a few friends at work, would really appreciate any critique from some people in the know though.
[deleted]
(remove spaces)
p.s the code is valid, but the web host i'm using adds an analytic code i cant remove or edit??
Last edited by M77 (January 21, 2009 12:53 pm)
Right off the top, ditch the red text. Those who are color blind and can't see red will see Dark Olive green on black. I think 30% of the population is colorblind, 90% of that are men and most often red cannot be seen.
Ditch the validation badges to. No one cares but us and we can check ourselves. It is really embarassing when you make a mistake in an update and do not test it and claim what is not valid to be valid.
PS - The M77 was a grenade launcher as I recall, Vietnam "Blooper" I believe.
(well I was almost right, it is a grenade launcher, but more modern, also a rocket launcher and even a spiral galaxy... let me guess, likely a highway in GB too.)
Nice work, considering you just started. Here is my list of suggestions:
Ditch the XHTML doctype and go with HTML - for an explanation, read the sticky in the HTML/XHTML forum here.
'click here' is kind of so 90s --- most folks nowadays know what to do when they see an underline
<h>s are meant to be used in order of importance - so you make your most important title on your page <h1>, the second most important <h2> and so on - you jump from <h1> to <h4>
Don't use <br>s inside <p>s - <br> is only for a line break - enclose every paragraph in <p> tags, and use your CSS to add spaced between the paragraphs.
Don't do <h3><b> - make is <h3> and then style that in your CSS.
Avoid inline styling - unless it's really something that will only happen one time on your entire site.
Drop the hit counter, too - it's amateurish.
And whatever LSW said - btw, I'm not colorblind, but that red on black is kind of hard on my eyes, too.
You have a few empty divisions - what's the point of those?
But other than that, VERY nice work for a first.
Firstly, thankyou for your input 
LSW quick color change and validation boxes done,
M77 is name related and just something a friend online started calling me, oh and yes it is a GB highway too, lol 
Thelma gonna start working through your suggestions 2moro, 
-HTML/XHTML, will check the sticky thanks
-dropped div's just need tidying up from other ideas i tried, tbh forgot,
<h's> <br's> etc trying to change things quickly, rather than correctly, lol 
-click here.. will remove, only added coz the friends i aimed the pages for have little pc knowledge.
Last edited by M77 (January 16, 2009 7:39 pm)
Let us know when you got that done so someone can take a look.
Copyright © 1996-2010 KillerSites.com | 
